-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated release pipeline #355
Add automated release pipeline #355
Conversation
The pipeline currently triggers when you push a semver tag but still requires you to update the version manually, we can implement automated versioning e.g. with |
--notes "" | ||
- name: Upload artifact signatures to GitHub Release | ||
env: | ||
GITHUB_TOKEN: ${{ github.token }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I missed this earlier, looks like if we want to push an automatic release as well we need to set up a github token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay cool-- so I need to set that up, somehow. It's int he docs you linked to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good point, no it's not. I'll open a PR to the packaging docs page to add a note.
I looked it up and looks like the token itself is automatically generated by GitHub, see docs.
However we would need to set the permissions so it has contents:write
access, see docs.
See also this post on stackoverflow.
To change the permissions go to https://github.com/duckdb/dbt-duckdb/settings/actions and scroll down to "Workflow permissions" and choose "Read and write permissions".
Alternatively you can create a Personal Access Token and use that instead of the GITHUB_TOKEN
.
If none of this sparks joy we can take this part out and just manually post release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also just realized that right now it posts empty release notes (--notes ""
)
Maybe a nice follow up PR could be to add automated release notes?
See: https://github.com/marketplace/actions/release-notes-generator#use-github-action
Edit: nvm I can just use --generate-notes
See packaging guide for setup instructions on PyPI:
This was tested on TestPyPI (see: https://test.pypi.org/project/dbt-duckdb/)