Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw HTTP error for status != 200 in InitializeMultipartUpload #10

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

Flogex
Copy link
Contributor

@Flogex Flogex commented Jan 8, 2025

Makes the error handling in InitializeMultipartUpload more consistent with UploadBuffer and checks for the HTTP status code before looking for the UploadId element. When the UploadID element is not found, a IOError is thrown now instead of an error that is displayed as "Invalid Error".

I also added a .gitignore.

@Mytherin Mytherin merged commit 47e7572 into duckdb:main Feb 4, 2025
24 checks passed
@Mytherin
Copy link
Contributor

Mytherin commented Feb 4, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants