Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout to default to 30 seconds instead of 30000 seconds #6

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Mytherin
Copy link
Contributor

Found by @ywelsch

httplib splits the timeout into two components (sec and usec):

Server &set_write_timeout(time_t sec, time_t usec = 0);

We were passing the timeout into the seconds component:

client->set_write_timeout(http_params.timeout);

With a somewhat high default value of 30000. This fixes it so the default is 30 seconds.

@carlopi
Copy link
Collaborator

carlopi commented Dec 11, 2024

This depends on #7, that should make CI work properly on main, I will have CI pass / merge that one, then check CI here.

@carlopi carlopi self-requested a review December 11, 2024 13:47
@Mytherin
Copy link
Contributor Author

Looks like CI has gone through - @carlopi good to merge?

@Mytherin Mytherin merged commit 84fb5f0 into main Dec 12, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants