Skip to content

Add httpfs_client_implementation option, currently only default and httplib are valid #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carlopi
Copy link
Collaborator

@carlopi carlopi commented Jul 3, 2025

Idea of this is allowing, in future versions of httpfs to offer a different version, namely curl, and possibly move the default.

Infrastructure would allow to register already in duckdb the option.

… `httplib` are valid in native, and `default` and `wasm` in wasm
@carlopi carlopi marked this pull request as ready for review July 3, 2025 15:46
@carlopi
Copy link
Collaborator Author

carlopi commented Jul 3, 2025

My idea is that this could go into 1.3.2, and then post 1.3.2 we can consider merging #58 (more ready form in #77), adding curl as alternative implementation, and have users try it out / give feedback already via:

SET httpfs_client_implementation = curl;

Then in a follow up / after relevant testing we could consider changing the default.

Copy link
Contributor

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@carlopi carlopi requested a review from Mytherin July 4, 2025 08:25
@carlopi
Copy link
Collaborator Author

carlopi commented Jul 4, 2025

Question is like: merge + add to 1.3.2 or to be done later?

@Tmonster
Copy link
Contributor

Tmonster commented Jul 4, 2025

I don't really see it adding any functionality that is necessary for v1.3.2, but it also seems like a relatively safe PR, so not against it. If I had to choose, I would say wait until after v1.3.2 then merge it so it is in CORE_NIGHTLY

@carlopi
Copy link
Collaborator Author

carlopi commented Jul 4, 2025

Yes, it's minor, only minor advantage is the fact that setting will be there in any version of httpfs in 1.3.2, vs being an error in some cases and present in others, but I can see also the call for that, and that's your call.

@carlopi carlopi mentioned this pull request Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants