Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/duckdb/src/function/table/version/pragma_version.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#ifndef DUCKDB_PATCH_VERSION
#define DUCKDB_PATCH_VERSION "3-dev132"
#define DUCKDB_PATCH_VERSION "3-dev136"
#endif
#ifndef DUCKDB_MINOR_VERSION
#define DUCKDB_MINOR_VERSION 4
Expand All @@ -8,10 +8,10 @@
#define DUCKDB_MAJOR_VERSION 1
#endif
#ifndef DUCKDB_VERSION
#define DUCKDB_VERSION "v1.4.3-dev132"
#define DUCKDB_VERSION "v1.4.3-dev136"
#endif
#ifndef DUCKDB_SOURCE_ID
#define DUCKDB_SOURCE_ID "9c1f71da3a"
#define DUCKDB_SOURCE_ID "136dd6ada5"
#endif
#include "duckdb/function/table/system_functions.hpp"
#include "duckdb/main/database.hpp"
Expand Down
9 changes: 9 additions & 0 deletions src/duckdb/src/storage/checkpoint/table_data_writer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,15 @@ void SingleFileTableDataWriter::FinalizeTable(const TableStatistics &global_stat
if (!v1_0_0_storage) {
options.emplace("v1_0_0_storage", v1_0_0_storage);
}

// If there is a context available, bind indexes before serialization.
// This is necessary so that buffered index operations are replayed before we checkpoint, otherwise
// we would lose them if there was a restart after this.
if (context && context->transaction.HasActiveTransaction()) {
info.BindIndexes(*context);
}
// FIXME: If we do not have a context, however, the unbound indexes have to be serialized to disk.

auto index_storage_infos = info.GetIndexes().SerializeToDisk(context, options);

auto debug_verify_blocks = DBConfig::GetSetting<DebugVerifyBlocksSetting>(GetDatabase());
Expand Down