Skip to content

Conversation

@qsliu2017
Copy link
Contributor

@qsliu2017 qsliu2017 commented Dec 22, 2025

I'm working on integrating ducklake with embed duckdb, e.g. pg_duckdb. This PR might be helpful to implement custom metadata manager.

Specifically, this PR:

  1. move all queries on metadata to DuckLakeMetadataManager::Query, so that custom implementation can override it to handle metadata queries.
  2. DuckLakeTransaction::Query only process queries on duckdb.

@qsliu2017 qsliu2017 changed the title Allow dynamically register metadata manager Move all queries on metadata to DuckLakeMetadataManager Dec 22, 2025
Copy link
Collaborator

@pdet pdet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @qsliu2017, thanks for the PR!
I’m a bit confused about why you wouldn’t need to replace these query variables if you were going to integrate with a different catalog. Can you expand on that?

@qsliu2017
Copy link
Contributor Author

why you wouldn’t need to replace these query variables if you were going to integrate with a different catalog.

Do you mean StringUtil::Replace(query, "{METADATA_CATALOG_NAME_LITERAL}", catalog_literal);? They've been moved to DuckLakeMetadataManager.

In my implementation, queries on metadata will not go through DuckLakeTransaction::Query, so it's better that we replace catalog related variables here.

@qsliu2017 qsliu2017 requested a review from pdet December 25, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants