first draft of generic masterchef fantom - #3
Open
flashfish0x wants to merge 7 commits into
Open
Conversation
fp-crypto
approved these changes
Feb 1, 2022
| address[] memory emissionTokenPath = new address[](2); | ||
| emissionTokenPath[0] = address(emissionToken); | ||
| emissionTokenPath[1] = address(usdc); | ||
| emissionTokenPath[1] = address(poolTwoSecondToken); |
There was a problem hiding this comment.
Might this ever need to be swapped via weth/wftm? In the case where address(want) == address(poolTwoSecondToken)?
Owner
There was a problem hiding this comment.
agree, one of the vaults is WFTM and the pool 2 is with WFTM, so we shouldn't need the second sell for it
Owner
There was a problem hiding this comment.
Nevermind, this should be handled just fine as-is
Author
There was a problem hiding this comment.
if want == secondtoken then we dont do the second
Owner
|
Would also be good to add an option for
as this is a template |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.