Remove duplicate createPHI and fix arg name typo.#15
Open
nick-ulle wants to merge 2 commits intoduncantl:masterfrom
Open
Remove duplicate createPHI and fix arg name typo.#15nick-ulle wants to merge 2 commits intoduncantl:masterfrom
nick-ulle wants to merge 2 commits intoduncantl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
createPhifunction usable.I'm not sure whyRLLVMCompile does not use either, so AFAIK we can safely remove one. The LLVM API definescreatePhiandcreatePHIwere both defined.createPHI, so it might be better to keep that name thancreatePhi. Having lots of duplicated function names makes the package more confusing than it needs to be.