Use specific route for login validation instead of systeminfo #157
+33
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a call to /systeminfo which is resource intensive to test the authentication status, this would use a new backend route /auth/validate which has near zero resource cost. The backend implementation is on [PR 6123](duplicati/duplicati#6123) meaning the ngclient would only work on with that once its merged and released.
sp90
reviewed
Apr 3, 2025
| @@ -31,7 +31,7 @@ export class AppAuthState { | |||
| }) | |||
| .pipe( | |||
| take(1), | |||
| tap((res) => res.AccessToken && this.#token.set(res.AccessToken)) | |||
There was a problem hiding this comment.
Should infer the type automatically
sp90
reviewed
Apr 3, 2025
| @@ -48,7 +48,7 @@ export class AppAuthState { | |||
|
|
|||
| return this.#dupServer.postApiV1AuthRefresh().pipe( | |||
| take(1), | |||
| tap((res) => res.AccessToken && this.#token.set(res.AccessToken)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a call to /systeminfo which is resource intensive to test the authentication status, this would use a new backend route /auth/validate which has near zero resource cost.
The backend implementation is on PR 6123 meaning the ngclient would only work on with that once its merged and released, hence why this PR will remain in draft.