root should not be optional, and should be the first argument.#1
Open
yields wants to merge 2 commits intodvv:masterfrom
yields:master
Open
root should not be optional, and should be the first argument.#1yields wants to merge 2 commits intodvv:masterfrom yields:master
yields wants to merge 2 commits intodvv:masterfrom
yields:master
Conversation
added 2 commits
May 30, 2012 09:02
Owner
|
Hi! Sorry for delay, i'm suffering connectivity issues. |
Author
|
this change seems right to me, i did it because root must be given and the mount can be defaulted. static('/', {root: __dirname})in my change he can just pass the root while the mount point can be defaulted. static(__dirname) |
Owner
|
i'm feeling like a middleware layer should explicitly define key parameters, the URL it's mounted on being the most important one. so far i tend to stay untouched, sorry. can you mangle your call to static middleware? thank you for heads up, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root is now the first argument, mount(point) is an option inside options
and defaults to
/.these changes make it possible to merge this excellent server into Rounded.