Prettier config improvements #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alexsapps
commented
Mar 18, 2025
•
alexsapps
commented
- Move all prettier config to root directory.
- Use prettier on all file types that it supports in VS Code and make fmt for consistency and to avoid spelling out every langauge to use it on.
- Require use of config file to run prettier in VS Code to avoid conflicting defaults between versions of prettier, and add config at root of project.
- Format unformatted files (some mjs files were not formatted previously).
jakehobbs
approved these changes
Mar 21, 2025
frontend-v2/pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
is this getting formatted? i think ideally lock files that are autogenerated don't get touched.
There was a problem hiding this comment.
whoops. fixed that and also realized prettier configs can't be nested so i moved all the config to the root directory.
alexsapps
force-pushed
the
alex/prettier
branch
2 times, most recently
from
71b856c to
8188901
Compare
* Define prettier config in a consistent way (always use .prettierrc.json file in both frontend packages). * Use prettier on all file types that it supports in VS Code and make fmt for consistency and to avoid spelling out every langauge to use it on. * Require use of config file to run prettier in VS Code to avoid conflicting defaults between versions of prettier, and add config at root of project. * Format unformatted files (some mjs files were not formatted previously).
alexsapps
force-pushed
the
alex/prettier
branch
2 times, most recently
from
1dee114 to
77897a6
Compare
Since prettier does not support nested configs.
alexsapps
force-pushed
the
alex/prettier
branch
from
77897a6 to
adbba8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.