Add social fields for international organizers #237
Conversation
frontend/ChapterList.vue
Outdated
| <b-table-column v-slot="props"> | ||
| <b-button @click="deleteOrganizer(props.row)"> | ||
| <b-icon icon="delete" type="is-danger"></b-icon> | ||
| </b-button> | ||
| </b-table-column> | ||
| <template #detail="props"> | ||
| <div style="display: flex; flex-wrap: wrap; gap: 10px"> |
There was a problem hiding this comment.
nit: i feel like there's a lot of space here. maybe gap-x 10px and gap-y 5px would look a little nicer
There was a problem hiding this comment.
just feels weird to me that there is more vertical space b/w these than there is b/w the "name email phone" fields and the top of this section.
| maxlength="100" | ||
| ></b-input> | ||
| </b-field> | ||
| <b-field label="Instagram" label-position="on-border" style="max-width: 300px"> |
There was a problem hiding this comment.
i wonder if we should do this style of labels for the "name email phone" fields too to keep it a bit more consistent?
There was a problem hiding this comment.
the table already has a header row that labels the columns themselves so individual labels aren't really necessary in table cells. lmk if i'm missing something though. and max-width doesn't matter as much since the table already forces 3 textboxes to share one line so those elements are never too wide.
| Facebook string | ||
| Instagram string | ||
| Twitter string | ||
| Website string |
There was a problem hiding this comment.
when reading organizers out of the db that don't already have these fields set in the json, i assume it will be fine and just return go's nil values (empty string)? my go is rusty....
There was a problem hiding this comment.
yeah i think so. i was able to add fields here after creating test organizers and they loaded fine.
alexsapps
force-pushed
the
alex/webpack-watch
branch
from
8455fe8 to
8d69568
Compare
alexsapps
force-pushed
the
alex/organizer-socials
branch
from
d91db93 to
e53363c
Compare
Looks like this: