Fix: catch specific exception and move to the next operation#12
Open
stefanospetrakis wants to merge 11 commits into1.xfrom
Open
Fix: catch specific exception and move to the next operation#12stefanospetrakis wants to merge 11 commits into1.xfrom
stefanospetrakis wants to merge 11 commits into1.xfrom
Conversation
The renderFullReport method was generating an explicit h2 header that duplicated the h3 header already provided by the analyze_table theme. This violates the analyze module design principles and creates inconsistent heading structure. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The renderFullReport method was generating an explicit h2 header that duplicated the h3 header already provided by the analyze_table theme. This violates the analyze module design principles and creates inconsistent heading structure. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Previously the AI Sentiments analysis view had no access restrictions. Now requires proper permission for security compliance. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix line length violations in README.md (lines 3, 8) - Fix line length violation in analyze_ai_sentiments.install (line 121) - Fix @return documentation format in AISentimentsAnalyzer.php (line 599) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add Configure settings button to sentiments analysis reports page - Use hook_views_pre_view with attachment_before for proper rendering - Match styling and positioning of View reports buttons on settings pages - Button appears above view content with proper form-actions styling - Remove unused action links file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix duplicate header clean
Fix duplicate h2/h3 header issue in renderFullReport
Changes from DefaultPluginManager to AnalyzePluginManager to match other working analyze modules. This resolves batch processing failures by ensuring the correct plugin manager is used to create analyzer instances. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Reduces batch processing chunk size to handle complex AI analysis requests that may take longer than other analyze modules, preventing MySQL connection timeouts during batch operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Reverts previous change as reducing batch size did not resolve the timeout issues. Restoring original chunk size of 5 entities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
@stefanospetrakis what is this for? |
Collaborator
Author
Pardon, here are the details, I think this should go in: Detailed in this PR:
Arguments for this code change:
In short: This change defends the code, makes the catch expectation more specific and adds a reaction to that specific expectation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.