Open
Conversation
Align error tooltip, loader, and placeholder naming with established codebase patterns (ck-ai-* prefix for CSS, consistent method names). Changes: - Rename IDs: gpt-error -> ck-ai-agent-error, gpt-response-loader -> ck-ai-agent-loader, slash-placeholder -> ck-ai-agent-placeholder - Rename CSS classes to use ck-ai-agent-* prefix with BEM modifiers (--visible, --warning) - Rename methods: showGptErrorToolTip -> showErrorTooltip, hideGptErrorToolTip -> hideErrorTooltip, addGptErrorToolTip -> createErrorTooltip - Update ID constants: GPT_RESPONSE_LOADER_ID -> LOADER_ID, GPT_RESPONSE_ERROR_ID -> ERROR_TOOLTIP_ID - Remove stray console.log from aiagentcontext.ts This removes inaccurate "GPT" references (the plugin supports multiple AI providers) and follows the ck-ai-* naming pattern used elsewhere in the codebase. BREAKING CHANGE: CSS class names changed. Users with custom styles targeting the old class names will need to update them. Fixes #177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align error tooltip, loader, and placeholder naming with established codebase patterns (
ck-ai-*prefix for CSS, consistent method names).ID Changes
gpt-errorck-ai-agent-errorgpt-response-loaderck-ai-agent-loaderslash-placeholderck-ai-agent-placeholderCSS Class Changes
response-errorck-ai-agent-errorshow-response-errorck-ai-agent-error--visibleresponse-error--warningck-ai-agent-error--warninggpt-loaderck-ai-agent-loadershow-gpt-loaderck-ai-agent-loader--visibleplace-holderck-ai-agent-placeholdershow-place-holderck-ai-agent-placeholder--visibleMethod Changes
showGptErrorToolTipshowErrorTooltiphideGptErrorToolTiphideErrorTooltipaddGptErrorToolTipcreateErrorTooltipConstant Changes
GPT_RESPONSE_LOADER_IDLOADER_IDGPT_RESPONSE_ERROR_IDERROR_TOOLTIP_IDThis removes inaccurate "GPT" references (the plugin supports multiple AI providers) and follows the
ck-ai-*naming pattern used elsewhere in the codebase.BREAKING CHANGE: CSS class names changed. Users with custom styles targeting the old class names will need to update them.
Fixes #177
Test plan