Open
Conversation
jjroelofs
requested changes
Nov 12, 2024
Contributor
jjroelofs
left a comment
There was a problem hiding this comment.
As we discussed earlier, please split up this PR into multiple PR, one test file per pull request. There is so much to review here, it will take me weeks with all the other things I have to do :)
Contributor
|
@me146 please also make the commit messages more descriptive, better ask ChatGPT to write a comprehensive commit message based on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the AiAssist and AiAssistEditing plugins with improved test coverage and configuration handling.