Skip to content

Meet/1.x/#24 regression tests and GitHub check#31

Open
me146 wants to merge 5 commits into1.xfrom
meet/1.x/#24-regression-tests-and-github-check
Open

Meet/1.x/#24 regression tests and GitHub check#31
me146 wants to merge 5 commits into1.xfrom
meet/1.x/#24-regression-tests-and-github-check

Conversation

@me146
Copy link
Copy Markdown
Collaborator

@me146 me146 commented Nov 7, 2024

This PR enhances the AiAssist and AiAssistEditing plugins with improved test coverage and configuration handling.

  • Added tests for AiAssistEditing to verify plugin loading, command registration, and Enter key handling.
  • Expanded AiAssist tests to check for required configurations and default settings.
  • Ensured errors are thrown for missing apiKey and invalid temperature values.
  • Updated schema to allow necessary elements, preventing insertion errors.

@me146 me146 requested a review from jjroelofs November 7, 2024 06:52
Copy link
Copy Markdown
Contributor

@jjroelofs jjroelofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed earlier, please split up this PR into multiple PR, one test file per pull request. There is so much to review here, it will take me weeks with all the other things I have to do :)

@jjroelofs
Copy link
Copy Markdown
Contributor

@me146 please also make the commit messages more descriptive, better ask ChatGPT to write a comprehensive commit message based on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants