chore: remove streamContent configuration from AiAgent and related fi…#72
Open
chore: remove streamContent configuration from AiAgent and related fi…#72
Conversation
…les to simplify the API and avoid confusion
24 tasks
jjroelofs
requested changes
Dec 24, 2024
Contributor
jjroelofs
left a comment
jjroelofs
left a comment
There was a problem hiding this comment.
more streamContent cleanup needed
Cleaning out streamContent variable is incomplete:
Remove stream setting elsewhere
Remove variable streaming config from functions downstream. It's just a source of bugs and streaming is a core UX feature of genAI. The fact the the docs of this param say streaming is disabled by default is a bug in itself and supports the idea that this param can do more harm than good.
https://github.com/dxpr/ckeditor5-ai-agent/blob/1.x/src/util/htmlparser.ts#L74
Contributor
|
this config might be useful after all, since o1 reasoning models dont support streaming on the API! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove streaming Content selection, as we always gonna stream content.