fix: replace outline:none with :focus-visible for keyboard navigation#777
Open
fix: replace outline:none with :focus-visible for keyboard navigation#777
Conversation
Co-authored-by: jjroelofs <[email protected]>
Primary tabs were being hidden for all users when admin_toolbar_tools was configured to show local tasks, even for users without toolbar permissions who couldn't see the tasks in the admin toolbar. Fixes #609 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Jurriaan Roelofs <[email protected]> Co-authored-by: Claude <[email protected]>
Previously, tabs were positioned with translate(-50%, -100%) which caused them to be hidden below the header on pages without a page title. Changed to translate(-50%, 0) to fix this issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…hout title" This reverts commit 1bd28e2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Solution
Replace blanket
outline: nonedeclarations with:focus:not(:focus-visible)selectors across frontend-facing SCSS files. This preserves the outline removal for mouse/touch users while restoring visible focus indicators for keyboard navigation, fixing WCAG 2.1 AA compliance (Success Criterion 2.4.7: Focus Visible).Files changed:
scss/base/typography.scss— global link focusscss/components/dxpr-theme-header.scss— header navigation linksscss/components/dxpr-theme-header--mobile.scss— mobile menu togglescss/vendor-extensions/drupal-pager.scss— pager active statescss/vendor-extensions/bootstrap-theme.scss— Bootstrap tab focusscss/vendor-extensions/bootstrap-5.scss— Bootstrap 5 active tabAdmin-only styles (
dxpr-theme.admin.themesettings.scss) are intentionally left unchanged as a separate concern.Checklist