clarify CSS cache build comments and remove misleading todo#778
Open
clarify CSS cache build comments and remove misleading todo#778
Conversation
Co-authored-by: jjroelofs <jjroelofs@users.noreply.github.com>
Primary tabs were being hidden for all users when admin_toolbar_tools was configured to show local tasks, even for users without toolbar permissions who couldn't see the tasks in the admin toolbar. Fixes #609 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Jurriaan Roelofs <jur@dxpr.com> Co-authored-by: Claude <noreply@anthropic.com>
Previously, tabs were positioned with translate(-50%, -100%) which caused them to be hidden below the header on pages without a page title. Changed to translate(-50%, 0) to fix this issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…hout title" This reverts commit 1bd28e2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Solution
Replace the misleading comment block and
@todointheme-settings.phpwith clear documentation explaining the actual CSS cache rebuild flow:if (!file_exists(...))) correctly only runs on first install or after cache cleardxpr_theme_form_system_theme_settings_after_submit()which clears the static cache and rebuilds with new valuesfile_exists()guard prevents thisThe submit handler flow is already correct and does not need code changes, just clearer documentation.
Checklist