Scope dropdown multi-column CSS to navigation menus#792
Merged
Conversation
The `.dropdown-menu:not(.dropdown-full-width .dropdown-menu) li` rule was nested under `.html` which is on the root <html> element, making it effectively global. This applied float:left, display:block, and min-width to <li> elements inside every Bootstrap dropdown on the page, breaking non-navigation dropdowns from other software components. Scope the selector to `.nav .dropdown-menu` to match only navigation context dropdowns, consistent with the enhanced-dropdowns.js initAutoColumns() which targets `.navbar-nav > .nav-item.dropdown > .dropdown-menu`. Fixes: #791
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Solution
The multi-column dropdown layout rule in
scss/vendor-extensions/bootstrap-5.scssused.dropdown-menu:not(.dropdown-full-width .dropdown-menu)nested under.html, making it effectively global. This appliedfloat: left,display: block, andmin-widthto<li>elements inside every Bootstrap.dropdown-menuon the page — including dropdowns from third-party modules and non-navigation components.Fixed by scoping the selector to
.nav .dropdown-menu:not(...), restricting it to Bootstrap navigation contexts. This is consistent with:enhanced-dropdowns.jsinitAutoColumns()which targets.navbar-nav > .nav-item.dropdown > .dropdown-menudxpr-theme-header--top.scsswhich scopes its dropdown rules under.block-system-menu-blockmainChecklist