Make links relative in sortable table header Nunjucks macro #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlivings-dxw
force-pushed
the
feature/nunjucks-as-express-rendering-engine
branch
from
3f782d4 to
9e1085b
Compare
The sortableTableHeader macro will generate links that use query parameters to control the sorting of the dashboard. However, as the table header links are of the form /?sortBy=<sort>&sortDirection=<direction>, they will only work correctly when used on the root path. To make them usable anywhere, just the query part of the URL can be used as the href, which will link to the current page with the updated query parameters.
danlivings-dxw
force-pushed
the
fix/use-relative-href-for-sortable-table-headers
branch
from
3a16e88 to
9605234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sortableTableHeadermacro will generate links that use query parameters to control the sorting of the dashboard. However, as the table header links are of the form/?sortBy=<sort>&sortDirection=<direction>, they will only work correctly when used on the root path. To make them usable anywhere, just the query part of the URL can be used as thehref, which will link to the current page with the updated query parameters.