Skip to content

feat: pnl leaderboard#36

Merged
dwjanus merged 5 commits intomainfrom
dwj/eng-1552-pnl-leaderboard
Jan 27, 2026
Merged

feat: pnl leaderboard#36
dwjanus merged 5 commits intomainfrom
dwj/eng-1552-pnl-leaderboard

Conversation

@dwjanus
Copy link
Collaborator

@dwjanus dwjanus commented Jan 26, 2026

Changes

  • update BonkPnlPanel to include incentives panel
  • use latest version of localization for incentives panel text

Issue

https://linear.app/dydx/issue/ENG-1552/make-bonktrade-only-pnl-leaderboard-monthly

Screenshot

image

@dwjanus dwjanus requested a review from a team as a code owner January 26, 2026 16:29
@linear
Copy link

linear bot commented Jan 26, 2026

@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
project-pup Error Error Jan 26, 2026 4:29pm

Request Review

Comment on lines 152 to 160
{stringGetter({ key: STRING_KEYS.POWERED_BY_ALL_CAPS })}{' '}
<Link
href="https://cryptolearningclub.org/"
isAccent
tw="font-small-bold"
title="Crypto Learning Club"
>
CLC
</Link>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this actually being sponsored by CLC?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, removing

</div>
),
label: 'Bonk PNL',
label: stringGetter({ key: STRING_KEYS.BONKUARY }),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this needs translation if its just BONKuary. Not sure how other languages will handle this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea i wasnt sure so i added it to localization jic. i can remove the translation here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk just keep an eye out if this gets translated into something we don't want to display

@dwjanus dwjanus merged commit e41a9f1 into main Jan 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants