Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Don't we need this change for both repos? |
Yes we do, although they will use different endpoints from what i understand so was gonna get this one out to make sure there are no issues and then pr similar changes to v4-web |
src/hooks/useSharePnlImage.ts
Outdated
| return undefined; | ||
| } | ||
|
|
||
| const userImage = await imageToBase64('/hedgie-profile.png'); |
There was a problem hiding this comment.
can't we just pass https://dydx.trade/hedgie-profile.png instead of the base64 version?
There was a problem hiding this comment.
or maybe even have the hedgie be the default on the image generator itself?
There was a problem hiding this comment.
oh yea we totally can, good call out - should also make this a default on the image generator for dydx cards.
src/hooks/useSharePnlImage.ts
Outdated
| enabled: Boolean(dydxAddress), | ||
| refetchOnWindowFocus: false, | ||
| refetchOnReconnect: false, | ||
| staleTime: 1000 * 60 * 2, // 2 minutes |
There was a problem hiding this comment.
need to replace this with timeUnits (done)
2 participants
Changes
Screenshots/Recordings (Optional)