Conversation
jaredvu
reviewed
Jun 18, 2025
| existing = existing, | ||
| new = new, | ||
| comparison = { obj, newItem -> | ||
| ParsingHelper.compare(obj.effectiveAtMilliSeconds, newItem.effectiveAtMilliSeconds, true) |
Collaborator
There was a problem hiding this comment.
I don't think effectiveAtMilliSeconds exist in the Indexer response. Are you creating this key later in the pipeline?
Contributor
Author
There was a problem hiding this comment.
This is the output data structure (actually copied from v3 two years ago). The data of this field comes from the "createdAt" field of the indexer response:
effectiveAtMilliSeconds = createdAt.toEpochMilliseconds().toDouble()
jaredvu
reviewed
Jun 18, 2025
| existing = existing, | ||
| incoming = new, | ||
| timeField = { item -> | ||
| item?.effectiveAtMilliSeconds?.toLong()?.let { |
Collaborator
There was a problem hiding this comment.
same question here. Also I think if you keep this key
effectiveAtMilliSeconds -> effectiveAtMilliseconds
Contributor
Author
There was a problem hiding this comment.
effectiveAtMilliSeconds is part of the output structure, so it should be fine...
jaredvu
previously approved these changes
Jun 18, 2025
jaredvu
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.