Add market-based fee discount and user staking discount #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruixhuang
commented
Oct 31, 2025
| ): Double? { | ||
| if (fee == null) return fee | ||
|
|
||
| var finalFee = fee |
Contributor
Author
Collaborator
There was a problem hiding this comment.
do you need to check if finalFee *= marketFeeDiscount.chargePercent is greater than 0 before applying the userStakingTierDiscountPercent?
@tqin7 would it ever be negative?
ruixhuang
commented
Oct 31, 2025
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class OnChainFeeDiscountsResponse( |
Contributor
Author
ruixhuang
commented
Oct 31, 2025
| @@ -0,0 +1,26 @@ | |||
| /** | |||
| * Indexer API | |||
Contributor
Author
ruixhuang
commented
Oct 31, 2025
| } | ||
|
|
||
| private fun retrieveUserStakingTier() { | ||
| val params = iMapOf("address" to accountAddress) |
Contributor
Author
ruixhuang
commented
Oct 31, 2025
| existing: InternalUserState?, | ||
| payload: OnChainUserStakingTierResponse?, | ||
| ): InternalUserState { | ||
| val internalState = existing ?: InternalUserState() |
Contributor
Author
ruixhuang
commented
Oct 31, 2025
|
|
||
| internal fun TradingStateMachine.onChainUserStakingTier(payload: String): StateChanges { | ||
| val json = parser.decodeJsonObject(payload) | ||
| val payload = parser.asTypedObject<OnChainUserStakingTierResponse>(json) |
Contributor
Author
jaredvu
reviewed
Nov 1, 2025
| try { | ||
| val newValue = PerpetualMarket( | ||
| id = name, | ||
| clobPairId = payload.clobPairId, |
jaredvu
reviewed
Nov 1, 2025
| val feeDiscountState = InternalMarketFeeDiscountState( | ||
| startTime = feeDiscount.startTime, | ||
| endTime = feeDiscount.endTime, | ||
| chargePercent = feeDiscount.chargePpm?.div(QUANTUM_MULTIPLIER), |
jaredvu
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ran codegen to update some of the indexer data models