Skip to content

Comments

Update memclob on ClobPair Update. (backport #3306)#3310

Merged
Kefancao merged 1 commit intorelease/protocol/v9.xfrom
mergify/bp/release/protocol/v9.x/pr-3306
Jan 14, 2026
Merged

Update memclob on ClobPair Update. (backport #3306)#3310
Kefancao merged 1 commit intorelease/protocol/v9.xfrom
mergify/bp/release/protocol/v9.x/pr-3306

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 14, 2026

Changelist

Currently the ClobPair update doesn't update the memclob, this PR will help do sync the memclob with the ClobPair.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Automatic synchronization of in-memory orderbook state when key ClobPair parameters are updated, preserving valid divisor relationships and preventing inconsistent state.
  • Tests

    • Added comprehensive tests covering validation rules, failure cases, and successful synchronization scenarios to ensure safe state updates.

✏️ Tip: You can customize this high-level summary in your review settings.


This is an automatic backport of pull request #3306 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner January 14, 2026 20:14
@mergify mergify bot mentioned this pull request Jan 14, 2026
6 tasks
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Kefancao Kefancao merged commit 3a99817 into release/protocol/v9.x Jan 14, 2026
18 of 19 checks passed
@Kefancao Kefancao deleted the mergify/bp/release/protocol/v9.x/pr-3306 branch January 14, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant