Skip to content

fix: check if control channel is closed before sending drop messages#349

Open
daydoing wants to merge 2 commits intodydxprotocol:mainfrom
daydoing:main
Open

fix: check if control channel is closed before sending drop messages#349
daydoing wants to merge 2 commits intodydxprotocol:mainfrom
daydoing:main

Conversation

@daydoing
Copy link

@daydoing daydoing commented Jun 2, 2025

No description provided.

@daydoing daydoing requested review from a team as code owners June 2, 2025 14:25
therustmonk
therustmonk previously approved these changes Jun 2, 2025
Copy link
Contributor

@therustmonk therustmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR, looks good!

@daydoing daydoing changed the title Check if control channel is closed before sending drop messages fix: check if control channel is closed before sending drop messages Jun 2, 2025
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daydoing ! Thanks a lot for the PR! The PR could only be merged if all commits are signed, so please re-commit everything :D

To easily do that you can make a soft reset, make a signed commit and then force-push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants