fix(composite-client): use of undefined variable#396
Draft
UnbornAztecKing wants to merge 3 commits intomainfrom
Draft
fix(composite-client): use of undefined variable#396UnbornAztecKing wants to merge 3 commits intomainfrom
UnbornAztecKing wants to merge 3 commits intomainfrom
Conversation
placeOrder exposes parameters for marketInfo and blockHeight, to avoid querying indexer and validator add parameters to signPlaceOrder to permit avoiding these queries if the information is available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXING MORE TYPESCRIPT ERRORS...
CompositeClient.signPlaceOrder made use of
wallet, which is undefined, instead ofsubaccount.walletThe package rules for typescript compilation and linting did not catch this bug and must be fixed in a separate change.
Changelist:
subaccount.wallet