add twap active orders table to the fe#1861
Draft
anmolagrawal345 wants to merge 4 commits intomainfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jaredvu
reviewed
Aug 27, 2025
Comment on lines
+239
to
+240
| case IndexerOrderStatus.ERROR: | ||
| return OrderStatus.Canceled; // Treat ERROR status as canceled |
Collaborator
There was a problem hiding this comment.
this case is already handled in line 232
jaredvu
reviewed
Aug 27, 2025
| return calculateOrderHistory(orders); | ||
| }); | ||
|
|
||
| export const selectTWAPOrders = createAppSelector([selectAccountOrders], (orders) => { |
Collaborator
There was a problem hiding this comment.
Is there need for selecting TWAP orders that aren't open?
Collaborator
There was a problem hiding this comment.
can simplify 148 to just filtering TWAP from selectOpenOrders instead
jaredvu
reviewed
Aug 27, 2025
Comment on lines
+221
to
+222
| "@injectivelabs/sdk-ts": "1.16.10", | ||
| "@injectivelabs/ts-types": "1.16.10" |
jaredvu
reviewed
Aug 27, 2025
| }, | ||
| { | ||
| value: 'OrderHistory', | ||
| label: 'Order History', |
jaredvu
reviewed
Aug 27, 2025
| const tabItems: TabItem<string>[] = [ | ||
| { | ||
| value: 'Active', | ||
| label: 'Active', |
jaredvu
reviewed
Aug 27, 2025
| import { Tabs, type TabItem } from '@/components/Tabs'; | ||
| import { ActiveTWAPTable, ActiveTWAPTableColumnKey } from './ActiveTWAPTable'; | ||
|
|
||
| const tabItems: TabItem<string>[] = [ |
Collaborator
There was a problem hiding this comment.
put in the component w/ useMemo
jaredvu
reviewed
Aug 27, 2025
| }, | ||
| { | ||
| value: 'Fills', | ||
| label: 'Fills', |
jaredvu
reviewed
Aug 27, 2025
| label: 'Order History', | ||
| content: ( | ||
| <div> | ||
| <h1>Order History</h1> |
jaredvu
reviewed
Aug 27, 2025
| label: 'Fills', | ||
| content: ( | ||
| <div> | ||
| <h1>Fills</h1> |
jaredvu
reviewed
Aug 27, 2025
|
|
||
| const tabItems: TabItem<string>[] = [ | ||
| { | ||
| value: 'Active', |
Collaborator
There was a problem hiding this comment.
or at least make it a type
type TWAPTableTabs = 'Active' | 'OrderHistory' | 'Fills';
Collaborator
There was a problem hiding this comment.
and use with the useState('Active')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.