Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jaredvu
reviewed
Jan 27, 2026
Comment on lines
56
to
57
| const isCopying = useRef(false); | ||
| const isSharing = useRef(false); |
Collaborator
There was a problem hiding this comment.
Using a ref here is probably not the correct move, especially if you want it to be used to display loading state in the buttons. If you are using a ref as a mutex with no UI changes this is ok.
jaredvu
reviewed
Jan 27, 2026
| await copyBlobToClipboard(pnlImage); | ||
| setIsCopied(true); | ||
| setTimeout(() => setIsCopied(false), 2000); | ||
| isCopying.current = false; |
Collaborator
There was a problem hiding this comment.
this mutex is never unlocked if their is an error copying to clipboard. We should wrap this in a try/catch and add a finally to unlock the state. If you switch the useRef to useState
if (isCopying || !pnlImage) return;
try {
setIsCopying(true);
...
} catch(err) {
setError(err);
} finally {
setIsCopying(false);
}
jaredvu
reviewed
Jan 27, 2026
Comment on lines
81
to
100
| const sharePnlImage = async () => { | ||
| if (isSharing.current || !pnlImage) return; | ||
| isSharing.current = true; | ||
| await copyBlobToClipboard(pnlImage); | ||
| setIsCopied(true); | ||
| setTimeout(() => setIsCopied(false), 2000); | ||
|
|
||
| triggerTwitterIntent({ | ||
| text: `${stringGetter({ | ||
| key: STRING_KEYS.TWEET_MARKET_POSITION, | ||
| params: { | ||
| MARKET: symbol, | ||
| }, | ||
| })}\n\n#bonk_trade #${symbol}\n[${stringGetter({ key: STRING_KEYS.TWEET_PASTE_IMAGE_AND_DELETE_THIS })}]`, | ||
| related: 'bonk_inu', | ||
| }); | ||
| isSharing.current = false; | ||
|
|
||
| dispatch(closeDialog()); | ||
| }; |
Collaborator
There was a problem hiding this comment.
same comments here as above.
jaredvu
reviewed
Jan 27, 2026
| action={ButtonAction.Primary} | ||
| slotLeft={<Icon iconName={IconName.SocialX} />} | ||
| onClick={() => { | ||
| track(AnalyticsEvents.SharePnlShared({ asset: assetId })); |
Collaborator
There was a problem hiding this comment.
this can prob be moved to the sharePnlImage function
jaredvu
reviewed
Jan 27, 2026
| action={ButtonAction.Secondary} | ||
| slotLeft={<Icon iconName={isCopied ? IconName.Check : IconName.Copy} />} | ||
| onClick={() => { | ||
| track(AnalyticsEvents.SharePnlCopied({ asset: assetId })); |
Collaborator
There was a problem hiding this comment.
can be moved to copyPnlImage()
jaredvu
reviewed
Jan 28, 2026
| onClick={() => copyPnlImage()} | ||
| state={{ | ||
| isLoading: !!isCopying.current, | ||
| isLoading: !!isCopying, |
jaredvu
reviewed
Jan 28, 2026
| onClick={() => sharePnlImage()} | ||
| state={{ | ||
| isLoading: !!isSharing.current, | ||
| isLoading: !!isSharing, |
jaredvu
reviewed
Jan 28, 2026
| track(AnalyticsEvents.SharePnlShared({ asset: assetId })); | ||
| sharePnlImage(); | ||
| }} | ||
| onClick={() => sharePnlImage()} |
jaredvu
reviewed
Jan 28, 2026
| track(AnalyticsEvents.SharePnlCopied({ asset: assetId })); | ||
| copyPnlImage(); | ||
| }} | ||
| onClick={() => copyPnlImage()} |
jaredvu
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Screenshots/Recordings (Optional)