Separated out an api controller#192
Open
mak001 wants to merge 5 commits into
Open
Conversation
pulled out methods from the locator controller and one from the locator page.
- removed old tests for stuff that was moved Fixed error on getLimit()
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
============================================
- Coverage 68.67% 66.94% -1.73%
- Complexity 90 102 +12
============================================
Files 7 8 +1
Lines 316 357 +41
============================================
+ Hits 217 239 +22
- Misses 99 118 +19
Continue to review full report at Codecov.
|
- added optional request parameter
jsirish
approved these changes
Sep 4, 2020
Member
jsirish
left a comment
jsirish
left a comment
There was a problem hiding this comment.
Looks good! Will need a rebase
muskie9
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out methods from the locator controller and one from the locator page.
Mostly for a locator block.
Resolves #109