-
Notifications
You must be signed in to change notification settings - Fork 669
Feat: Print sandbox inspect url on sandbox spawn #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: Print sandbox inspect url on sandbox spawn #841
Conversation
🦋 Changeset detectedLatest commit: 32a2abb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@ben-fornefeld can you use team slug instead of team ID? |
that would probably require a re-auth. will check tomorrow! |
The auth command needs to be changed in order to retrieve the slug as well as the team id, but currently signed teams will see the their team id in the link (since the slug was not fetched before). |
@mishushakov i have an idea how to make this logic not dependent on the client side at all. i will just check in the dashboard via wdyt? |
we should try this! |
- Introduced a new utility function `printDashboardSandboxInspectUrl` to streamline the process of generating and printing the sandbox inspection URL. - Updated the `createCommand` function to utilize the new utility instead of the previous direct URL construction method. - Added a new constant `DASHBOARD_BASE` for better URL management.
done. tested on the following pr/preview: e2b-dev/dashboard#141 |
NOTE: this pr can be reviewed already, but merging needs to be blocked until e2b-dev/dashboard#141 is deployed. |
This PR updates the sandbox spawn process to print the inspect URL to the console when a new sandbox is created using
e2b sbx spawn
ore2b sbx create
. This makes it easier for users to access and debug new sandboxes directly after creation.