-
Notifications
You must be signed in to change notification settings - Fork 670
feat: pretty default logs for build helper #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6f79952 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c8dc2b5
to
4f5daa9
Compare
d497313
to
af5ab11
Compare
af5ab11
to
4c694bc
Compare
6fca7e4
to
e269bad
Compare
ad817d7
to
51c3426
Compare
51c3426
to
c3ef49d
Compare
timestamp=datetime.now(), | ||
level="info", | ||
message="Waiting for logs...", | ||
message="Build finished", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Build Completion Logging Misleads on Failures
The build
method's finally
block always emits a "Build finished" log entry, even if an exception occurs during the build. This can be misleading when a build fails.
Additional Locations (2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't have better idea, I'm open to change it
Example usages
The default log level is now
INFO
Note
Introduces pretty default build loggers for JS/Python SDKs, emits start/end build logs, and updates CLI templates/tests to use them.
packages/js-sdk
):defaultBuildLogger
with colored output (chalk
); newlogger.ts
.LogEntry
,LogEntryStart
,LogEntryEnd
,LogEntryLevel
fromtemplate
and rootindex
.onBuildLogs?: (logEntry: LogEntry) => void
.TemplateBase.build
now emitsLogEntryStart
/LogEntryEnd
and structured info logs.packages/python-sdk
):default_build_logger
with pretty output (rich
).LogEntryLevel
,LogEntryStart
,LogEntryEnd
; export via__init__
.Template.build
/AsyncTemplate.build
emit start/end logs and structured info logs.pyrightconfig.json
; update deps inpyproject.toml
and lockfile.packages/cli
)onBuildLogs: defaultBuildLogger()
, Pythonon_build_logs=default_build_logger()
.onBuildLogs
signature.chalk
.rich
(and new transitive packages).@e2b/python-sdk
,e2b
, and@e2b/cli
.Written by Cursor Bugbot for commit 6f79952. This will update automatically on new commits. Configure here.