-
Notifications
You must be signed in to change notification settings - Fork 202
Refactor dirty page tracking #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el uffd handling to a subpackage
dobrac
approved these changes
Nov 10, 2025
Member
Author
|
I'll do some last end-to-end testing and then we should be able to merge. |
6eb0bd8 to
070ddb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Refactors dirty-page tracking to a new block Tracker, updates UFFD to unregister and return tracked pages via Disable(ctx), and wires changes through sandbox, build diffs, and tests.
block.Tracker; addDisable(ctx) (*block.Tracker, error)and remove directDirty()fromMemoryBackend.uffd.Newdrops block-size param;Uffd.Disablenow unregisters mappings (addsUFFDIO_UNREGISTER) and returns tracker; internaldirty(ctx)helper added.userfaultfd.NewUserfaultfdFromFd; limit in-flight requests to4096.TrackerwithAdd/Has/Reset/Clone/Offsets/BitSet/BlockSize;Slicernow requiresBlockSize().bitsetOffsetsand iter-based offsets.memory.Disable(ctx)to get dirty pages; passdirty.BitSet()to memory diff; updateserveMemoryto newuffd.Newsignature.BlockSize()toDiffimplementations (NoDiff,localDiff,StorageDiff).tracker_test.go; revise cross-process test to streamTracker.Offsets(); addutils.TransformToiterator helper; testMemorySlicernow implementsBlockSize().Written by Cursor Bugbot for commit 8dc51d0. This will update automatically on new commits. Configure here.