Skip to content

Conversation

@jakubno
Copy link
Member

@jakubno jakubno commented Dec 2, 2025

  • Eliminates the need for a local Docker client during Terraform runs. This improves portability and avoids failures on systems where Docker isn’t available or configured.
  • Corrects an issue where Terraform would incorrectly resolve a locally cached :latest image. Terraform now consistently pulls/uses the intended remote image instead of relying on stale local state.

Note

Switch Terraform image references to Google Artifact Registry data sources (dropping Docker provider/resources) and relocate Docker auth from the composite action to the build workflow.

  • Infrastructure (Terraform/Nomad):
    • Replace Docker provider/resources with google_artifact_registry_docker_image data sources in nomad/images.tf and update Nomad jobs to use .self_link for api, db-migrator, docker-reverse-proxy, client-proxy, and clickhouse-migrator images.
    • Remove Docker and Grafana providers/config from main.tf; simplify required providers.
  • CI/CD:
    • Remove Docker setup from ./.github/actions/deploy-setup/action.yml.
    • Add Docker auth/setup step to .github/workflows/build-and-upload-job.yml.
  • Lockfile:
    • Drop grafana/grafana and kreuzwerker/docker providers from iac/provider-gcp/.terraform.lock.hcl.

Written by Cursor Bugbot for commit b78d4a5. This will update automatically on new commits. Configure here.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@dobrac dobrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice change 🙌

@jakubno jakubno merged commit 9a3a2f5 into main Dec 2, 2025
28 checks passed
@jakubno jakubno deleted the remove-docker-provider-from-terraform branch December 2, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants