fix(linkgraph): recover hyphenated infobox Related-concept aliases - #1948
Conversation
Infobox "Related concept" values are free text, not always the exact article title. invalid_reveal_commit_hash_not_match and no_weights_commit_found both set Related concept to "Commit-reveal", but the target article is titled "Commit Reveal" (slug commit_reveal). slugify() only turns spaces into underscores, so the hyphenated form never matched any generated alias key and the edge was silently dropped. buildSlugAliases now also registers the opposite hyphen/underscore variant for every alias key that contains either, so either spelling of a compound term resolves to the same article.
|
Verdict: Close PR #1948: fix(linkgraph): recover hyphenated infobox Related-concept aliases This PR is labeled Cross-repo validation:
[2286052:0x43d39000] 62024 ms: Scavenge (interleaved) 975.2 (1003.6) -> 974.5 (1003.6) MB, pooled: 0 MB, 61.17 / 0.00 ms (average mu = 0.530, current mu = 0.388) allocation failure; <--- JS stacktrace ---> FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory 1: 0xe42d60 node::OOMErrorHandler(char const*, v8::OOMDetails const&) [node] Automated review by Taopedia Site Maintainer. |
|
Verdict: Close PR #1948: fix(linkgraph): recover hyphenated infobox Related-concept aliases This PR is labeled Cross-repo validation:
Synced 682 published articles from taopedia-articles Automated review by Taopedia Site Maintainer. |
|
Verdict: Close Automerge was blocked by final merged-result validation. Final validation:
�[2m19:31:35�[22m �[34m[content]�[39m Syncing content �[42m�[30m generating static routes �[39m�[49m The bot validates the PR merged into the latest target branch before merging. Automated review by Taopedia Site Maintainer. |
There was a problem hiding this comment.
Verdict: Auto-merge approved
PR #1948: fix(linkgraph): recover hyphenated infobox Related-concept aliases
Codebase value:
- Codex and Claude agreed the site/codebase improvement is worth the added maintenance surface.
Automated reviewers:
- Codex: The PR fixes a present generated-data correctness issue for existing article content and is locally/GitHub validated.
- Claude: approve
Cross-repo validation:
- pass merged checkout: PR head 688cc52 merges cleanly into test. Build/render is validated by the required GitHub Actions
buildcheck.
Automated review by Taopedia Site Maintainer.
Summary
Commit-reveal) instead of the article's space-separated title (Commit Reveal, slugcommit_reveal)buildSlugAliasesnow also registers the opposite hyphen/underscore variant for every alias key that contains either, so either spelling of a compound term resolves to the same article (never overwriting an existing alias, matching the existing first-write-wins rule)Target Branch
testTesting
npm run test:linkgraph-data-orderpassesnpm run test:linkgraph-infoboxpassesnpm run test:linkgraph-slug-collisionpassesnpm run buildpassesSecurity Checklist
Current article infoboxes already set
Related concept: Commit-reveal(a hyphenated compound), but the linkgraph currently drops that edge even though a matching local article (commit_reveal, titled "Commit Reveal") already exists, becauseslugify()only turns spaces into underscores and never touches an author-written hyphen, so the hyphenated label never matches any alias key generated from the article's own slug/title.Examples fixed by the generated-data checks in this diff:
invalid_reveal_commit_hash_not_matchnow links locally tocommit_revealfrom its infoboxRelated concept: Commit-revealno_weights_commit_foundnow links locally tocommit_revealfrom its infoboxRelated concept: Commit-reveal