fix(a11y): enhance toolbar toggle accessibility with aria-controls attributes - #1962
Closed
carlh7777 wants to merge 1 commit into
Closed
fix(a11y): enhance toolbar toggle accessibility with aria-controls attributes#1962carlh7777 wants to merge 1 commit into
carlh7777 wants to merge 1 commit into
Conversation
…tributes ## Summary Add `aria-controls` attributes to the appearance and navigation toolbar toggle buttons, and ensure the sidebar and appearance panels have stable IDs for better screen reader support. ## Why This Should Ship This change improves accessibility for keyboard users and screen readers by clearly indicating which elements the toggle buttons control, ensuring that assistive technologies can accurately convey the state of the UI. ## Review Notes - `npm run test:mobile-header-search` passes. - No visible UI change; behavior-only accessibility enhancement. - Touches `[...slug].astro`, `WikiLayout.astro`, and `scripts/check-mobile-header-search.js`. ## Target Branch - [x] This PR targets `test` - [ ] This PR targets `main` only because it promotes `test` to production ## Security Checklist - [x] No secrets, tokens, build hooks, wallet seeds, or private endpoints are included - [x] No unnecessary workflow, dependency, or deployment changes
taopedia-site-maintainer
Bot
added
the
other
|
Verdict: Close PR #1962: fix(a11y): enhance toolbar toggle accessibility with aria-controls attributes This PR changes focus-driven on-screen behavior. Code analysis confirms the visible effect only appears during the interaction, so static before/after screenshots cannot demonstrate it (an identical-looking pair is not valid evidence). A short screen recording or GIF is required. Visual PRs need evidence in the PR description so the maintainer can review the change quickly and reliably. A deploy preview link alone is not enough. Required evidence for resubmission:
Changed files:
CI: All required CI checks passed: build Please open a new focused PR with the required evidence attached. Automated review by Taopedia Site Maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
aria-controlsattributes to the appearance and navigation toolbar toggle buttons, and ensure the sidebar and appearance panels have stable IDs for better screen reader support.Why This Should Ship
This change improves accessibility for keyboard users and screen readers by clearly indicating which elements the toggle buttons control, ensuring that assistive technologies can accurately convey the state of the UI.
Review Notes
npm run test:mobile-header-searchpasses.[...slug].astro,WikiLayout.astro, andscripts/check-mobile-header-search.js.Target Branch
testmainonly because it promotestestto productionSecurity Checklist