fix(special): align most linked pages list layout - #1964
Closed
andriypolanski wants to merge 2 commits into
Closed
Conversation
|
Verdict: Needs visual approval PR #1964: fix(special): align most linked pages list layout Engineering:
Changed files:
Guardrails:
Decision surface:
What to check:
Preview links:
Cross-repo validation:
Human decision:
Automated review by Taopedia Site Maintainer. |
Owner
|
/close |
|
Closing by maintainer command Automated review by Taopedia Site Maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the Most linked pages special page list layout so article titles and link counts are easier to scan.
Changes in
src/pages/wiki/special/mostlinkedpages.astro:<ol>to<ul>(unordered list, no numbered markers).padding-left: 32px→padding: 0).margin-left: autoon.mw-ml-count).Affected route:
/wiki/special/mostlinkedpages/This is a website-only UI change in this repository. No article/content changes from
taopedia-articlesare included, consistent with the repo split described in README.md.Why This Should Ship
The Most Linked Pages view serves as a navigation surface for the most frequently referenced articles across Taopedia. In the previous layout, the list was visually indented away from the main page content, creating a UI/UX inconsistency compared to other pages.
The updated layout resolves this inconsistency by aligning the content structure with the rest of the interface, ensuring a more cohesive and consistent user experience.
Ranking data is unchanged. The page still uses
buildMostLinkedPages()fromscripts/most-linked.js, the same source as/wiki/special/mostlinkedpages.json.Review Notes
Per CONTRIBUTING.md:
test(notmain).--border-color-subtle,--color-base-subtle); no hardcoded light/dark colors./wiki/special/mostlinkedpages/Most linked pagesheadingValidation
npm run dev # Open http://localhost:4321/wiki/special/mostlinkedpages/ npm run build npm run test:most-linkedExisting regression checks in
scripts/check-most-linked.jsstill match the same row markup (mw-ml-row,mw-ml-title,mw-ml-count); only list semantics and CSS changed.Target Branch
testmainonly because it promotestestto productionSecurity Checklist
Before
After
Test Plan
/wiki/special/mostlinkedpages/locally and confirm the list is an unordered list (no numbers).Most linked pagesheading.npm run test:most-linkedafternpm run build.