-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify conf.xml #3062
Comments
Can you provide an example of an "inline" which is troublesome to you? |
@duncdrum 's suggestion is to switch on/off functionality (e.g modules) with a flag, instead of putting configuration parts in XML comments. |
@dizzzz I still don't understand what that would look like vs what it looks like currently |
I think @duncdrum <!--
<module uri="http://exist-db.org/xquery/spatial"
class="org.exist.xquery.modules.spatial.SpatialModule"/>
--> vs <module uri="http://exist-db.org/xquery/spatial"
class="org.exist.xquery.modules.spatial.SpatialModule" enabled="no"/> rationale: it is easier to switch on/off modules with e.g. an xslt script. |
yes similarly allow triggers to be enabled / disabled <!--<trigger class="org.exist.collections.triggers.XQueryStartupTrigger"/>--> as well as <!--
<job class="bar.foo.myjob" period="600000" delay="300000" repeat="10" />
--> and <!--
<feature name="http://xml.org/sax/features/external-general-entities" value="false"/>
<feature name="http://xml.org/sax/features/external-parameter-entities" value="false"/>
<feature name="http://javax.xml.XMLConstants/feature/secure-processing" value="true"/>
--> for consistencies sake i would also consider <custom-filter class="org.exist.FirstFilter"/>
<backup-filter class="org.exist.FirstFilter"/> |
|
@dizzzz we could also enable the wrapper Element. Or Uncomment but with reversed values from what is in there now. The main goal still being to get rid of inlines. |
Another inline hold up is the actual version of a This is less than stellar, as copying a v3.3 |
What is the problem
conf.xml
still has a few linline holdouts. These are tricky to process via standard xsl/xquery and unnecessarily complicate hand-off configuration of exist. A boolean@enablded
attribute would be easier to process, and to read.What did you expect
Easy modability of conf.xml using standard xml tricks.
First step
@enabled
to conf schema , uncomment all inlines and set to@enabled="false"
@enabled="false|true"
wherever it was added in step 1.next…
consider if modules need to be loaded via manual configuration at all, or if a
beans.xml
style cdi approach can improve this process further.Context information
The text was updated successfully, but these errors were encountered: