Skip to content

[Bugfix] small number formatted with exponent fails #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
+13 −3
Draft

[Bugfix] small number formatted with exponent fails #5946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db650b6
[bugfix] Add test for #5943 small number formatted with exponent fails
dizzzz Nov 24, 2025
7b85a6e
[bugfix] proposed fix for #5943 small number formatted with exponent…
dizzzz Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions exist-core/src/main/java/org/exist/xquery/functions/fn/FnFormatNumbers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,9 +714,6 @@ private String format(final NumericValue number, final DecimalFormat decimalForm
final int minimumExponentSize = subPicture.getMinimumExponentSize();
if (minimumExponentSize > 0) {
formatted.append(decimalFormat.exponentSeparator);
if (exp < 0) {
formatted.append(decimalFormat.minusSign);
}

final CodePointString expStr = new CodePointString(String.valueOf(exp));

Expand Down
13 changes: 13 additions & 0 deletions exist-core/src/test/xquery/numbers/format-numbers.xql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,4 +303,17 @@ declare
%test:assertEquals("0.0")
function fd:decimal-zeros($picture as xs:string) {
format-number(0, $picture)
};

declare
%test:args(1.234567E10,"0.000e0")
%test:assertEquals("1.235e10")
%test:args(1.234567E-10,"0.000e0")
%test:assertEquals("1.235e-10")
%test:args(0.000000000123456,"0.000e0")
%test:assertEquals("1.235e-10")
%test:args(1.234567e-10,"0.000e0")
%test:assertEquals("1.235e-10")
function fd:exponent-fails($number as xs:double, $picture as xs:string) {
format-number($number, $picture)
};
Loading