Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map constructor syntax #32

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

joewiz
Copy link
Member

@joewiz joewiz commented Jul 23, 2019

@dizzzz dizzzz merged commit 70262f7 into eXist-db:develop Jul 23, 2019
@joewiz joewiz deleted the fix-map-constructor-syntax branch July 24, 2019 01:45
@joewiz
Copy link
Member Author

joewiz commented Jul 24, 2019

@dizzzz Thanks! Shall I prepare a new release, or would you prefer to do this? Either way is fine with me.

@dizzzz
Copy link
Member

dizzzz commented Jul 24, 2019

We indeed should prepare a new release, all is set for now. (htough it might be good to verify if the XAR works both on v4 and v5)

@joewiz
Copy link
Member Author

joewiz commented Jul 24, 2019

@dizzzz Cool. Shall I just increment the version number (to a new patch release), build the xar and publish it - i.e., the old way? Or is the procedure outlined in #31 ready to go?

@PieterLamers
Copy link

jfreechart-showcase/modules/view.xql still has the following (using no longer supported := map key:value separator):

let $config := map {
    $templates:CONFIG_APP_ROOT := $config:app-root,
    $templates:CONFIG_STOP_ON_ERROR := true()
}

fixed that on my localhost. Don't know how to push changes to GIT yet tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants