retry on compaction/branch summarization retryable failures - #6775
Closed
davidbrai wants to merge 3 commits into
Closed
retry on compaction/branch summarization retryable failures#6775davidbrai wants to merge 3 commits into
davidbrai wants to merge 3 commits into
Conversation
Contributor
|
Absolutely not my place, but wouldn't defaulting to whatever is set in user settings/retry be more expected than static one immediate retry? I get that setting is conceptually for something a bit different but as I used I'd expect it to govern most/all agentic layer operations. Compaction being one of them. |
Contributor
Author
|
@petrroll yes, I agree. will update soon |
Contributor
|
@davidbrai Please see if you can make the retry (and transport) settinfs available to extensions. If I need to call models from the extension, I would prefer to have an option to use the current settings. |
Collaborator
@xl0 separate concern :) |
Contributor
Author
|
closing. will open a separate pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6647
@badlogic questions: