Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWD: Add missing radar site "Emden" (EMD, wmo=10204) #335

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 27, 2021

Hi there,

according to wradlib/wradlib-notebooks#49 (comment), Emden is missing in the official publication koordinaten-radarverbund.pdf. Thanks for spotting this, @kmuehlbauer.

a) This patch adds it back. Can you verify the coordinates, Kai?
b) We should also notify [email protected] about it.

With kind regards,
Andreas.

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #335 (88ce9cc) into main (43bd45c) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   90.33%   90.44%   +0.11%     
==========================================
  Files          54       54              
  Lines        2783     2784       +1     
  Branches      284      284              
==========================================
+ Hits         2514     2518       +4     
+ Misses        213      211       -2     
+ Partials       56       55       -1     
Flag Coverage Δ
unittests 90.44% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wetterdienst/dwd/radar/sites.py 45.00% <100.00%> (+0.93%) ⬆️
wetterdienst/dwd/radar/access.py 90.00% <0.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43bd45c...8fba9db. Read the comment docs.

@kmuehlbauer
Copy link
Collaborator

a) This patch adds it back. Can you verify the coordinates, Kai?

At least they are the same as in the wradlib documentation. I think I took it from the Komposit-Format description

b) We should also notify [email protected] about it.

Yes. It would be good, if they would maintain a document which lists the current radar stations (as of now) and keep track of stations which have been relocated or being used while others haven been reconstructed.

@gutzbenj
Copy link
Member

Thanks for taking care, @amotl !

@amotl
Copy link
Member Author

amotl commented Jan 27, 2021

Hi again,

thanks for your insights. While I can't find back the reference, you told us the other day that within wradlib/wradlib-notebooks you might have used an outdated version of the list of radar sites.

Now, when looking at the situation again, the document Metadata on the radars of the DWD radar network (koordinaten-radarverbund.pdf) was updated in April, 2018 while the document Description of the "Komposit-Format" Version 2.5.1 (radolan_radvor_op_komposit_format_pdf.pdf) was updated in October, 2020.

So, I conclude we should actually adjust the PDF parser [1] to use the more recently updated document as a reference. After distilling a patch from that, we will see what might have changed. To go forward on this, I will merge this patch and then eventually submit another one.

On the other hand, it obviously would be perfect if we could find a machine readable source for this data. But this is still amiss as far as you know?

With kind regards,
Andreas.

[1] https://github.com/earthobservations/wetterdienst/blob/v0.13.0/wetterdienst/dwd/radar/sites.py#L178-L287

@amotl amotl merged commit 15d4566 into main Jan 27, 2021
@amotl amotl deleted the amo/radar-emden branch January 27, 2021 21:32
@amotl
Copy link
Member Author

amotl commented Feb 4, 2021

According to [1] p. 16, the radar site in Emden went out of service on 2018-02-27. Apparently, ASR Borkum is the replacement site for Emden since 2018.

ASR=Ausfallsicherungsradar: Während der Erneuerung der alten Single- zu Dual-Pol-Doppler-Radaren im Rahmen des Projekts RadSys-E war ein ASR zur Aufrechterhaltung der Wetterüberwachung am Standort Essen, Feldberg, Rostock bzw. Dresden in der Zeit von 2010 bis 2015 in Betrieb. Seit 2018 wird das ASR als Ersatz des Radars Emden auf Borkum eingesetzt.

So, we might want to remove EMD again - or shall we also maintain defunct sites for historical reasons in this list, @kmuehlbauer? Just let me know if you are occasionally processing old data or whether it would be safe to remove it again. Thanks!

[1] https://www.dwd.de/DE/leistungen/radolan/radolan_info/radolan_radvor_op_komposit_format_pdf.pdf?__blob=publicationFile

@kmuehlbauer
Copy link
Collaborator

Thanks @amotl, as DWD keeps historic RADOLAN data and this data is widely used for scientific purposes it would be good to have all radar site locations available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants