-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DWD: Add missing radar site "Emden" (EMD, wmo=10204) #335
Conversation
Codecov Report
@@ Coverage Diff @@
## main #335 +/- ##
==========================================
+ Coverage 90.33% 90.44% +0.11%
==========================================
Files 54 54
Lines 2783 2784 +1
Branches 284 284
==========================================
+ Hits 2514 2518 +4
+ Misses 213 211 -2
+ Partials 56 55 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
At least they are the same as in the wradlib documentation. I think I took it from the Komposit-Format description
Yes. It would be good, if they would maintain a document which lists the current radar stations (as of now) and keep track of stations which have been relocated or being used while others haven been reconstructed. |
Thanks for taking care, @amotl ! |
Hi again, thanks for your insights. While I can't find back the reference, you told us the other day that within Now, when looking at the situation again, the document Metadata on the radars of the DWD radar network (koordinaten-radarverbund.pdf) was updated in April, 2018 while the document Description of the "Komposit-Format" Version 2.5.1 (radolan_radvor_op_komposit_format_pdf.pdf) was updated in October, 2020. So, I conclude we should actually adjust the PDF parser [1] to use the more recently updated document as a reference. After distilling a patch from that, we will see what might have changed. To go forward on this, I will merge this patch and then eventually submit another one. On the other hand, it obviously would be perfect if we could find a machine readable source for this data. But this is still amiss as far as you know? With kind regards, |
11e00c4
to
e432d44
Compare
e432d44
to
8fba9db
Compare
According to [1] p. 16, the radar site in Emden went out of service on 2018-02-27. Apparently, ASR Borkum is the replacement site for Emden since 2018.
So, we might want to remove EMD again - or shall we also maintain defunct sites for historical reasons in this list, @kmuehlbauer? Just let me know if you are occasionally processing old data or whether it would be safe to remove it again. Thanks! |
Thanks @amotl, as DWD keeps historic RADOLAN data and this data is widely used for scientific purposes it would be good to have all radar site locations available. |
Hi there,
according to wradlib/wradlib-notebooks#49 (comment), Emden is missing in the official publication koordinaten-radarverbund.pdf. Thanks for spotting this, @kmuehlbauer.
a) This patch adds it back. Can you verify the coordinates, Kai?
b) We should also notify
[email protected]
about it.With kind regards,
Andreas.