Add --keep-going option to fail at the end not at first failing installation
#5022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to install any possible easyconfig without stopping if a single one fails
Thyre
reviewed
Oct 9, 2025
Co-authored-by: Jan André Reuter <[email protected]>
Collaborator
|
Here's the output for a very simple test, trying to install Intel compilers on aarch64 and some other EasyConfig at the same time: Used command: Output: Click to openSo this is working as expected. Might come in very handy in preparing 2025a on this system for PR testing... |
Collaborator
|
There are errors which this doesn't catch. Mainly, I've encountered these two so far: The second case is arbitrarily made up, but came up due to the EasyStack I used being created with an EasyConfig not existing upstream. Don't know how easy it would be to catch such cases as well, since they also abort This honestly isn't a blocker though, as one can still use flags to work around the former and should make sure that the files exist for the latter. |
Contributor
Author
|
I think having no or missing easyconfigs should error in any case as it might hint that you mistyped an option or similar issue where it might not do what you expected. And we can argue that this option is documented to continue on a failed build and if it fails to parse it is a different issue. |
Collaborator
Absolutely, a missing EasyConfig should error out in any case. I'm fine with keeping the current behavior for all three ( |
Contributor
Author
IIRC we have And failing to parse an easyconfig could as well be that you accidentally passed an easyblock or patch instead of an easyconfig, so again it isn't a build issue which we want to ignore with this option. If this can be made more clear in the description we could do that. But as it fails right at the start I think it is fine as-is. |
boegel
requested changes
Dec 3, 2025
easybuild/main.py
Outdated
Comment on lines
787
to
789
| if options.dump_test_report or options.upload_test_report: | ||
| # Generation test reports is successful even when software failed to build | ||
| return EasyBuildExit.SUCCESS |
Member
There was a problem hiding this comment.
Hmm, not sure about this...
Exit code should always indicate whether (all) installations were successful or not, regardless of whether a test report was uploaded/dumped? That seems like the least surprising behavior to me...
Contributor
Author
There was a problem hiding this comment.
Shouldn't the exit code indicate an error in the requested operation? And a failed installation while explicitly testing for those isn't an error.
So it's a definition issue and I'm not fully sure how to solve it, so either way is fine to me. Hence I'm changing this to an error as suggested
Thyre
reviewed
Dec 3, 2025
Member
|
@Flamefire merge conflict to fix... |
Contributor
Author
|
Resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to install any possible easyconfig without stopping if a single one fails
The main function will call
sys.exitwith the returned exit code as-if failing by anEasyBuildErrorsoeb --keep-going ec1.eb ec2-ebwill return an error code that can be used in scripts