-
Notifications
You must be signed in to change notification settings - Fork 2
163 resolution function to class #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with minor stylistic comments
It is now possible to serialize the resolution function.
To obtain this a class for resolution functions has been introduced.
ResolutionFunction
PercentageFhwm
LinearSpline
Had to do some cleaning to ensure that the
as_dict
for the different classes are called.base_element_collection.py
model_collection.py
Docs have been reordered