Skip to content

163 resolution function to class #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 17, 2024
Merged

Conversation

andped10
Copy link
Collaborator

@andped10 andped10 commented May 15, 2024

It is now possible to serialize the resolution function.

To obtain this a class for resolution functions has been introduced.

  • ResolutionFunction
    • PercentageFhwm
    • LinearSpline

Had to do some cleaning to ensure that the as_dict for the different classes are called.

  • base_element_collection.py
  • model_collection.py

Docs have been reordered

@andped10 andped10 linked an issue May 15, 2024 that may be closed by this pull request
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@andped10 andped10 added [scope] bug Bug report or fix (major.minor.PATCH) chore Chore changes to the code labels May 15, 2024
@andped10 andped10 requested a review from rozyczko May 16, 2024 09:36
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with minor stylistic comments

@andped10 andped10 merged commit 63f2689 into master May 17, 2024
30 checks passed
@andped10 andped10 deleted the 163-resolution-function-to-class branch May 17, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore changes to the code [scope] bug Bug report or fix (major.minor.PATCH)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolution function to class
2 participants