-
Notifications
You must be signed in to change notification settings - Fork 2
Constraints serialization #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
henrikjacobsenfys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is essentially bringing back the unique ID's as far as I understand? If this is needed to make serialization work, then it looks good to me.
damskii9992
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to be able to resolve dependencies specifically in an object hierarchy?
We can make all of this much simpler if we simply use the global map and always resolve all pending dependencies.
all_parameters = [param for param in global_map.vertices() if param isinstance DescriptorNumber && hasattr(param, '_pending_dependency_string')]For my remaining comments I made another PR with my suggested changes. It is mostly integrating your code further with the observer pattern and getting rid of the unique_name fallback as I don't see any use of that.
Details in the
PARAMETER_DEPENDENCY_SERIALIZATION.mdfile.The file is to be moved to the docs once they're actually present.