Skip to content

Conversation

@rozyczko
Copy link
Member

Details in the PARAMETER_DEPENDENCY_SERIALIZATION.md file.
The file is to be moved to the docs once they're actually present.

@rozyczko rozyczko added [scope] enhancement Adds/improves features (major.MINOR.patch) feature PR label [priority] medium Normal/default priority [area] Serialization Anything related to serialization labels Oct 16, 2025
Copy link
Member

@henrikjacobsenfys henrikjacobsenfys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is essentially bringing back the unique ID's as far as I understand? If this is needed to make serialization work, then it looks good to me.

Copy link
Contributor

@damskii9992 damskii9992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to be able to resolve dependencies specifically in an object hierarchy?
We can make all of this much simpler if we simply use the global map and always resolve all pending dependencies.

all_parameters = [param for param in global_map.vertices() if param isinstance DescriptorNumber && hasattr(param, '_pending_dependency_string')]

For my remaining comments I made another PR with my suggested changes. It is mostly integrating your code further with the observer pattern and getting rid of the unique_name fallback as I don't see any use of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[area] Serialization Anything related to serialization feature PR label [priority] medium Normal/default priority [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants