Type hints #38
Merged
Type hints #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozyczko
added
the
[scope] maintenance
There was a problem hiding this comment.
Overall, it looks good. There were quite a lot of changes, so it's a bit tricky to go through everything in detail 🙂
One minor thing I noticed - it wasn't clear to me why Any was used in some places instead of more specific types like SampleModels, Experiments, Calculator, etc.
github-project-automation
bot
moved this from In Review
to Done
in New EasyDiffractionLib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type hints throughout the code. Additionally, doctrings were added to methods and classes.
The branch is based off of
unit_tests, so I could immediately check the code for issues.This is why it should be merged into that branch first, before
unit_testsis merged withdevelop