Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for the certificate file to be passed in through the providerArg parameter #275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

efetoboreakpoguma
Copy link
Contributor

@efetoboreakpoguma efetoboreakpoguma commented Jan 29, 2025

Backgroud

Please see the details about this bug here.

Possible Solution

There are several solutions to this issue but I have opted to go with this one as it involves the smallest possible change.
Currently, the configArg is used to pass in the keyStore value to the JsignJcaProvider. This PR adds the ability to pass in a comma-separated as the configArg where the first element is keyStore and the second element is the configArg.

Also, the configArg can:

  • be null.
  • contain just the keystore.
  • contain both the keystore and certfile.

Testing

See the passed build here.

Summary

As I said above, this is a possible solution. If you decide to go with this approach, we would need to update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant