Add People update method and SSL verification option#10
Merged
Conversation
Adds configurable SSL verification to allow bypassing certificate verification in development/test environments while keeping it enabled by default. - Add ssl_verify attribute to Configuration (default: true) - Update HttpClient to use config.ssl_verify - Update Client documentation with new option - SSL verification can be disabled with: ssl_verify: false This is useful for development in regions with certificate chain issues.
Updated tests to verify that: - ssl_verify: true (default) sets verify_mode to VERIFY_PEER - ssl_verify: false sets verify_mode to VERIFY_NONE The old tests expected verify_mode NOT to be set, but now we explicitly configure it based on the ssl_verify option.
Owner
Author
|
@claude please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds new functionality to the NationBuilder API client gem to support profile updates and configurable SSL verification.
Key features:
Changes
People Update Method
client.people.update(id, attributes:)method/api/v2/signups/{id}endpoint withtype: "signups"Usage:
SSL Verification Option
ssl_verifyconfiguration option (default:true)Usage:
Multi-tenant Support
Bug Fixes
Files Changed
lib/nationbuilder_api/resources/people.rb- Added update methodlib/nationbuilder_api/configuration.rb- Added ssl_verify optionlib/nationbuilder_api/http_client.rb- Implemented SSL verification togglelib/nationbuilder_api/client.rb- Updated documentationspec/nationbuilder_api/resources/people_spec.rb- Added comprehensive testsREADME.md- Updated documentation with new featuresagent-os/specs/SPEC_ADD_PEOPLE_UPDATE.md- Added specification documentTesting
Added RSpec tests covering:
Related Work
This enables the profile editing feature in the Citizen app (ebrett/citizen#48).
🤖 Generated with Claude Code