Add V1 API support for people taggings and tags#12
Merged
Conversation
Implements GitHub issue #11 to provide V1 API methods for managing person taggings and listing tags. V2 API does not include tag names or provide tag management endpoints, so V1 API support is required. Added People resource methods: - list_taggings(person_id) - GET /api/v1/people/:id/taggings Returns taggings with tag names (V2 only returns IDs) - add_tagging(person_id, tag_name) - PUT /api/v1/people/:id/taggings Adds a tag to a person - remove_tagging(person_id, tag_name) - DELETE /api/v1/people/:id/taggings/:tag Removes a tag from a person Added Tags resource: - list() - GET /api/v1/tags Lists all available tags The existing V2 taggings() method is preserved for backward compatibility but now includes a note that it doesn't return tag names. All methods include comprehensive RSpec tests. Test coverage: 92.83% Resolves: #11 Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements GitHub issue #11 to provide V1 API methods for managing person taggings and listing tags. The V2 API does not include tag names or provide tag management endpoints, so V1 API support is required for these operations.
Changes
People Resource - V1 API Methods
list_taggings(person_id)- GET /api/v1/people/:id/taggingsadd_tagging(person_id, tag_name)- PUT /api/v1/people/:id/taggingsremove_tagging(person_id, tag_name)- DELETE /api/v1/people/:id/taggings/:tagTags Resource - V1 API
list()- GET /api/v1/tagsDocumentation
taggings()method for backward compatibilityTesting
Impact
This allows applications using the gem to:
Related Issues
Closes #11
🤖 Generated with Claude Code