-
Notifications
You must be signed in to change notification settings - Fork 57
Performance: /api/content_node/checklist_nodes #7114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace DoctrineMigrations; | ||
|
||
use Doctrine\DBAL\Schema\Schema; | ||
use Doctrine\Migrations\AbstractMigration; | ||
|
||
/** | ||
* Auto-generated Migration: Please modify to your needs! | ||
*/ | ||
final class Version20250324224924 extends AbstractMigration { | ||
public function getDescription(): string { | ||
return 'ContentNode.RootId not nullable'; | ||
} | ||
|
||
public function up(Schema $schema): void { | ||
// this up() migration is auto-generated, please modify it to your needs | ||
$this->addSql('ALTER TABLE content_node ALTER rootId SET NOT NULL'); | ||
} | ||
|
||
public function down(Schema $schema): void { | ||
// this down() migration is auto-generated, please modify it to your needs | ||
$this->addSql('ALTER TABLE content_node ALTER rootid DROP NOT NULL'); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ public function testCreateColumnLayoutValidatesMissingParent() { | |
$this->assertJsonContains([ | ||
'violations' => [ | ||
[ | ||
'propertyPath' => 'parent', | ||
'propertyPath' => 'root', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test name still says the parent may not be missing, not the root. Should this be a new test instead? Or do we just need to adjust the test's name? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately no. |
||
'message' => 'This value should not be null.', | ||
], | ||
], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, so this finally works now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - and it improves performance :)